From a79b5e1a4bfd10dd1375db516099c3fcc8f53b52 Mon Sep 17 00:00:00 2001
From: pepe iborra <pepeiborra@gmail.com>
Date: Sun, 14 Jul 2019 16:02:55 +0100
Subject: [PATCH 1/2] Add support for Implicit Params

I don't know what I'm doing, but it type checks

Closes #246
---
 src-literatetests/14-extensions.blt           | 16 +++++++++++
 .../Brittany/Internal/Layouters/Decl.hs       | 28 +++++++++++++++++--
 .../Brittany/Internal/Layouters/Expr.hs       | 10 +++++--
 3 files changed, 49 insertions(+), 5 deletions(-)

diff --git a/src-literatetests/14-extensions.blt b/src-literatetests/14-extensions.blt
index 12facda..1dc5cf8 100644
--- a/src-literatetests/14-extensions.blt
+++ b/src-literatetests/14-extensions.blt
@@ -140,3 +140,19 @@ foo = #bar
 #test applied and composed label
 {-# LANGUAGE OverloadedLabels #-}
 foo = #bar . #baz $ fmap #foo xs
+
+###############################################################################
+## ImplicitParams
+
+#test IP usage
+{-# LANGUAGE ImplicitParams #-}
+foo = ?bar
+
+#test IP binding
+{-# LANGUAGE ImplicitParams #-}
+foo = let ?bar = Foo in value
+
+#test IP type signature
+{-# LANGUAGE ImplicitParams #-}
+foo :: (?bar::Bool) => ()
+foo = ()
\ No newline at end of file
diff --git a/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs b/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs
index c7a7d04..9a81727 100644
--- a/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs
+++ b/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs
@@ -32,6 +32,7 @@ import           GHC                            ( runGhc
                                                 , AnnKeywordId(..)
                                                 )
 import           SrcLoc ( SrcSpan, noSrcSpan, Located , getLoc, unLoc )
+import qualified FastString
 import           HsSyn
 #if MIN_VERSION_ghc(8,6,0)
 import           HsExtension (NoExt (..))
@@ -231,6 +232,23 @@ layoutBind lbind@(L _ bind) = case bind of
                                                             hasComments
   _ -> Right <$> unknownNodeError "" lbind
 
+layoutIPBind :: ToBriDoc IPBind
+layoutIPBind lipbind@(L _ bind) = case bind of
+#if MIN_VERSION_ghc(8,6,0)   /* ghc-8.6 */
+  XIPBind{} -> unknownNodeError "XIPBind" lipbind
+  IPBind _ (Right _) _ -> error "unreachable"
+  IPBind _ (Left (L _ (HsIPName name))) expr -> do
+#else
+  IPBind (Right _) _ -> error "unreachable"
+  IPBind (Left (L _ (HsIPName name))) expr -> do
+#endif
+    ipName <- docLit $ Text.pack $ '?' : FastString.unpackFS name
+    binderDoc <- docLit $ Text.pack "="
+    exprDoc <- layoutExpr expr
+    hasComments <- hasAnyCommentsBelow lipbind
+    layoutPatternBindFinal Nothing binderDoc (Just ipName) [([], exprDoc, expr)] Nothing hasComments
+
+
 data BagBindOrSig = BagBind (LHsBindLR GhcPs GhcPs)
                   | BagSig (LSig GhcPs)
 
@@ -268,8 +286,14 @@ layoutLocalBinds lbinds@(L _ binds) = case binds of
     Just . (: []) <$> unknownNodeError "HsValBinds ValBindsOut{}"
                                        (L noSrcSpan x)
 #endif
-  x@(HsIPBinds{}) ->
-    Just . (: []) <$> unknownNodeError "HsIPBinds" (L noSrcSpan x)
+#if MIN_VERSION_ghc(8,6,0)   /* ghc-8.6 */
+  x@(HsIPBinds _ XHsIPBinds{}) ->
+    Just . (: []) <$> unknownNodeError "XHsIPBinds" (L noSrcSpan x)
+  HsIPBinds _ (IPBinds _ bb) ->
+#else
+  HsIPBinds (IPBinds bb _) ->
+#endif
+    Just <$> mapM layoutIPBind bb
   EmptyLocalBinds{} -> return $ Nothing
 
 -- TODO: we don't need the `LHsExpr GhcPs` anymore, now that there is
diff --git a/src/Language/Haskell/Brittany/Internal/Layouters/Expr.hs b/src/Language/Haskell/Brittany/Internal/Layouters/Expr.hs
index d08824b..43797cd 100644
--- a/src/Language/Haskell/Brittany/Internal/Layouters/Expr.hs
+++ b/src/Language/Haskell/Brittany/Internal/Layouters/Expr.hs
@@ -64,9 +64,13 @@ layoutExpr lexpr@(L _ expr) = do
 #endif
       let label = FastString.unpackFS name
       in docLit . Text.pack $ '#' : label
-    HsIPVar{} -> do
-      -- TODO
-      briDocByExactInlineOnly "HsOverLabel{}" lexpr
+#if MIN_VERSION_ghc(8,6,0)   /* ghc-8.6 */
+    HsIPVar _ext (HsIPName name) ->
+#else
+    HsIPVar (HsIPName name) ->
+#endif
+      let label = FastString.unpackFS name
+      in docLit . Text.pack $ '?' : label
 #if MIN_VERSION_ghc(8,6,0)   /* ghc-8.6 */
     HsOverLit _ olit -> do
 #else

From 6c69388d73b34f112ef68961353fc697a53799ac Mon Sep 17 00:00:00 2001
From: Lennart Spitzner <hexagoxel@hexagoxel.de>
Date: Fri, 19 Jul 2019 00:12:04 +0200
Subject: [PATCH 2/2] Make errors more descriptive

This is defensive against GHC API guarantees.
---
 src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs b/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs
index 9a81727..0dc05a7 100644
--- a/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs
+++ b/src/Language/Haskell/Brittany/Internal/Layouters/Decl.hs
@@ -236,10 +236,10 @@ layoutIPBind :: ToBriDoc IPBind
 layoutIPBind lipbind@(L _ bind) = case bind of
 #if MIN_VERSION_ghc(8,6,0)   /* ghc-8.6 */
   XIPBind{} -> unknownNodeError "XIPBind" lipbind
-  IPBind _ (Right _) _ -> error "unreachable"
+  IPBind _ (Right _) _ -> error "brittany internal error: IPBind Right"
   IPBind _ (Left (L _ (HsIPName name))) expr -> do
 #else
-  IPBind (Right _) _ -> error "unreachable"
+  IPBind (Right _) _ -> error "brittany internal error: IPBind Right"
   IPBind (Left (L _ (HsIPName name))) expr -> do
 #endif
     ipName <- docLit $ Text.pack $ '?' : FastString.unpackFS name