From 75aed1cb8a44816baedc5cc50149dfd796a9b0fd Mon Sep 17 00:00:00 2001
From: Taylor Fausak <taylor@fausak.me>
Date: Sat, 6 Nov 2021 21:11:27 +0000
Subject: [PATCH] Remove unnecessary GHC version parsing

---
 src-literatetests/10-tests.blt      |  3 ---
 src-literatetests/14-extensions.blt |  5 ++---
 src-literatetests/Main.hs           | 25 ++-----------------------
 3 files changed, 4 insertions(+), 29 deletions(-)

diff --git a/src-literatetests/10-tests.blt b/src-literatetests/10-tests.blt
index aa3c7cb..75babb0 100644
--- a/src-literatetests/10-tests.blt
+++ b/src-literatetests/10-tests.blt
@@ -446,7 +446,6 @@ data Foo = Bar
   deriving (Show, Eq, Monad, Functor, Traversable, Foldable)
 
 #test record multiple deriving strategies
-#min-ghc 8.2
 data Foo = Bar
   { foo  :: Baz
   , bars :: Bizzz
@@ -461,7 +460,6 @@ data Foo = Bar
   deriving newtype (Traversable, Foldable)
 
 #test record deriving via
-#min-ghc 8.6
 data Foo = Bar
   { foo  :: Baz
   , bars :: Bizzz
@@ -535,7 +533,6 @@ data Foo = Bar
 ## maybe we want to switch to a differnt layout when there are such comments.
 ## Don't hesitate to modify this testcase, it clearly is not the ideal layout
 ## for this.
-#min-ghc 8.6
 
 data Foo = Bar
   { foo  :: Baz
diff --git a/src-literatetests/14-extensions.blt b/src-literatetests/14-extensions.blt
index d794e9c..18fc24f 100644
--- a/src-literatetests/14-extensions.blt
+++ b/src-literatetests/14-extensions.blt
@@ -121,7 +121,7 @@ pattern myLeftVariableName `MyInfixPatternMatcher` myRightVariableName <-
   [myLongLeftVariableName, myLongRightVariableName] where
   MyInfixPatternMatcher x y = [x, x, y]
 
-#test Pattern synonym types 
+#test Pattern synonym types
 {-# LANGUAGE PatternSynonyms #-}
 pattern J :: a -> Maybe a
 pattern J x = Just x
@@ -152,7 +152,6 @@ pattern Signed x <- (asSigned -> x) where
   Signed (Pos x) = x  -- positive comment
 
 #test Pattern synonym types multiple names
-#min-ghc 8.2
 {-# LANGUAGE PatternSynonyms #-}
 pattern J, K :: a -> Maybe a
 
@@ -239,4 +238,4 @@ foo = let ?bar = Foo in value
 #test IP type signature
 {-# LANGUAGE ImplicitParams #-}
 foo :: (?bar::Bool) => ()
-foo = ()
\ No newline at end of file
+foo = ()
diff --git a/src-literatetests/Main.hs b/src-literatetests/Main.hs
index a1dc2af..d11007b 100644
--- a/src-literatetests/Main.hs
+++ b/src-literatetests/Main.hs
@@ -1,9 +1,7 @@
-{-# LANGUAGE CPP #-}
 {-# LANGUAGE LambdaCase #-}
 {-# LANGUAGE MonadComprehensions #-}
 
 import Language.Haskell.Brittany.Internal.Prelude
-import qualified Data.List.Extra
 import qualified Data.Maybe
 import qualified Data.Semigroup as Semigroup
 import qualified Data.Text as Text
@@ -32,7 +30,6 @@ import           System.FilePath                ( (</>) )
 data InputLine
   = GroupLine Text
   | HeaderLine Text
-  | GhcVersionGuardLine Text
   | PendingLine
   | NormalLine Text
   | CommentLine
@@ -41,7 +38,6 @@ data InputLine
 data TestCase = TestCase
   { testName :: Text
   , isPending :: Bool
-  , minGHCVersion :: Maybe Text
   , content :: Text
   }
 
@@ -56,26 +52,17 @@ main = do
   let groups = createChunks =<< inputs
   inputCtxFree <- Text.IO.readFile "src-literatetests/30-tests-context-free.blt"
   let groupsCtxFree = createChunks inputCtxFree
-  let parseVersion :: Text -> Maybe [Int]
-      parseVersion =
-        mapM (readMaybe . Text.unpack) . Text.splitOn (Text.pack ".")
-  let ghcVersion = Data.Maybe.fromJust $ parseVersion $ Text.pack VERSION_ghc
-  let checkVersion = \case
-        Nothing -> True -- no version constraint
-        Just s  -> case parseVersion s of
-          Nothing -> error $ "could not parse version " ++ Text.unpack s
-          Just v  -> v <= ghcVersion
   hspec $ do
     groups `forM_` \(groupname, tests) -> do
       describe (Text.unpack groupname) $ do
-        tests `forM_` \test -> when (checkVersion $ minGHCVersion test) $ do
+        tests `forM_` \test -> do
           (if isPending test then before_ pending else id)
             $ it (Text.unpack $ testName test)
             $ roundTripEqual defaultTestConfig
             $ content test
     groupsCtxFree `forM_` \(groupname, tests) -> do
       describe ("context free: " ++ Text.unpack groupname) $ do
-        tests `forM_` \test -> when (checkVersion $ minGHCVersion test) $ do
+        tests `forM_` \test -> do
           (if isPending test then before_ pending else id)
             $ it (Text.unpack $ testName test)
             $ roundTripEqual contextFreeTestConfig
@@ -113,15 +100,12 @@ main = do
         in  TestCase
               { testName      = n
               , isPending     = any isPendingLine rest
-              , minGHCVersion = Data.List.Extra.firstJust extractMinGhc rest
               , content       = Text.unlines normalLines
               }
       l ->
         error $ "first non-empty line must start with #test footest\n" ++ show l
     extractNormal (NormalLine l) = Just l
     extractNormal _              = Nothing
-    extractMinGhc (GhcVersionGuardLine v) = Just v
-    extractMinGhc _                       = Nothing
     isPendingLine PendingLine{} = True
     isPendingLine _             = False
     specialLineParser :: Parser InputLine
@@ -138,11 +122,6 @@ main = do
         , name <- Parsec.many1 $ Parsec.noneOf "\r\n:"
         , _    <- Parsec.eof
         ]
-      , [ GhcVersionGuardLine $ Text.pack version
-        | _       <- Parsec.try $ Parsec.string "#min-ghc"
-        , _       <- Parsec.many1 $ Parsec.oneOf " \t"
-        , version <- Parsec.many1 $ Parsec.noneOf "\r\n:"
-        ]
       , [ PendingLine
         | _ <- Parsec.try $ Parsec.string "#pending"
         , _ <- Parsec.optional $ many (Parsec.noneOf "\r\n")