hexagoxel
/
brittany
1
0
Fork 0
Code Issues 117 Pull Requests 5 Packages Projects Releases 5 Wiki Activity

cabal new-install brittany fails #162

New Issue
Closed
opened 2018-07-11 13:16:00 +02:00 by andreabedini · 12 comments
andreabedini commented 2018-07-11 13:16:00 +02:00 (Migrated from github.com)

The README suggests the following procedure

cabal unpack brittany
cd brittany-0.11.0.0
# cabal new-configure -w $PATH_TO_GHC_8_0
cabal new-build exe:brittany
# and it should be safe to just copy the executable, e.g.
cp `find dist-newstyle/ -name brittany -type f | xargs -x ls -t | head -n1` $HOME/.cabal/bin/

I wondered why cabal new-install would not work and indeed it doesn't

command: cabal new-install -j1 brittany
Resolving dependencies...
Build profile: -w ghc-8.4.3 -O1
In order, the following will be built (use -v for more details):
 - brittany-0.11.0.0 (exe:brittany) (requires build)
Configuring executable 'brittany' for brittany-0.11.0.0..
clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
Preprocessing executable 'brittany' for brittany-0.11.0.0..
Building executable 'brittany' for brittany-0.11.0.0..

src-brittany/Main.hs:7:10: error:
     fatal error: 'prelude.inc' file not found
  |
7 | #include "prelude.inc"
  |          ^
#include "prelude.inc"
         ^~~~~~~~~~~~~
1 error generated.
`clang' failed in phase `C pre-processor'. (Exit code: 1)
Symlinking brittany

Very verbose output available in https://gist.github.com/gwils/918a8c5cf169716e9c5c502c0bb7f7f6

I am not sure if this is a problem in brittany or in cabal but hexagoxel on #hackage suggested I'd open the issue here. I might open it on cabal too.

The README suggests the following procedure ``` cabal unpack brittany cd brittany-0.11.0.0 # cabal new-configure -w $PATH_TO_GHC_8_0 cabal new-build exe:brittany # and it should be safe to just copy the executable, e.g. cp `find dist-newstyle/ -name brittany -type f | xargs -x ls -t | head -n1` $HOME/.cabal/bin/ ``` I wondered why `cabal new-install` would not work and indeed it doesn't ``` command: cabal new-install -j1 brittany Resolving dependencies... Build profile: -w ghc-8.4.3 -O1 In order, the following will be built (use -v for more details): - brittany-0.11.0.0 (exe:brittany) (requires build) Configuring executable 'brittany' for brittany-0.11.0.0.. clang: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument] Preprocessing executable 'brittany' for brittany-0.11.0.0.. Building executable 'brittany' for brittany-0.11.0.0.. src-brittany/Main.hs:7:10: error: fatal error: 'prelude.inc' file not found | 7 | #include "prelude.inc" | ^ #include "prelude.inc" ^~~~~~~~~~~~~ 1 error generated. `clang' failed in phase `C pre-processor'. (Exit code: 1) Symlinking brittany ``` Very verbose output available in https://gist.github.com/gwils/918a8c5cf169716e9c5c502c0bb7f7f6 I am not sure if this is a problem in brittany or in cabal but hexagoxel on #hackage suggested I'd open the issue here. I might open it on cabal too.
lspitzner commented 2018-07-11 13:42:16 +02:00 (Migrated from github.com)

@andreabedini

Could you try the following fix: In brittany.cabal, add

  include-dirs:
    srcinc

to the executable component. Those lines are already present in the library component, but it looks like new-install needs it on all components. Which makes sense, all of them use the include. Kind of curious that this oversight was not noticed sooner :-)

@andreabedini Could you try the following fix: In `brittany.cabal`, add ~~~~ include-dirs: srcinc ~~~~ to the executable component. Those lines are already present in the library component, but it looks like new-install needs it on all components. Which makes sense, all of them use the include. Kind of curious that this oversight was not noticed sooner :-)
andreabedini commented 2018-07-11 15:32:50 +02:00 (Migrated from github.com)

Thanks @lspitzner. I did have a go but the problem seems more complex.

  1. I am not sure cabal new-install works at all for local packages (so I can't just apply your change to my working copy)
  2. @fgaz on IRC pointed me to haskell/cabal#5399 (from which I dug up haskell/cabal#4120, which seems more relevant)

¯_(ツ)_/¯

Thanks @lspitzner. I did have a go but the problem seems more complex. 1) I am not sure cabal new-install works at all for local packages (so I can't just apply your change to my working copy) 2) @fgaz on IRC pointed me to haskell/cabal#5399 (from which I dug up haskell/cabal#4120, which seems more relevant) ¯\_(ツ)_/¯
lspitzner commented 2018-07-11 16:28:11 +02:00 (Migrated from github.com)

Right, that was an uninformed suggestion. Presuming that it does not noticeably make anything worse I will include the potential fix in the next release (which is not too far away, ghc-8.6 compat). I don't see a need to make a release sooner just for testing this.

Fortunately I think that 4120 is not relevant as brittany does not use data-files.

We can leave this issue open as a reminder to test things after the next release.

Right, that was an uninformed suggestion. Presuming that it does not noticeably make anything worse I will include the potential fix in the next release (which is not too far away, ghc-8.6 compat). I don't see a need to make a release sooner just for testing this. Fortunately I think that 4120 is not relevant as brittany does not use data-files. We can leave this issue open as a reminder to test things after the next release.
hvr commented 2018-07-13 00:30:27 +02:00 (Migrated from github.com)

@lspitzner btw, adding include-dirs: srcinc to the exe stanza is imo not the proper way to fix this!

The problem is rather that

library 
  install-includes: srcinc/prelude.inc 
  include-dirs: srcinc

specifies the install-includes with an explicit path, instead of

library 
  install-includes: prelude.inc 
  include-dirs: srcinc

then things should work, and there'd be no need to change anything in the exe component.

@lspitzner btw, adding `include-dirs: srcinc` to the exe stanza is imo not the proper way to fix this! The problem is rather that ``` library install-includes: srcinc/prelude.inc include-dirs: srcinc ``` specifies the `install-includes` with an explicit path, instead of ``` library install-includes: prelude.inc include-dirs: srcinc ``` then things should work, and there'd be no need to change anything in the exe component.
👍 1
lspitzner commented 2018-07-13 21:12:13 +02:00 (Migrated from github.com)

@hvr oh, good point. thanks for the correction!

@hvr oh, good point. thanks for the correction!
lspitzner commented 2018-07-13 21:27:45 +02:00 (Migrated from github.com)

although.. i don't really see the need to expose prelude.inc outside of the package. So I guess removing "install-includes" entirely plus per-component "include-dirs" is the way to go?

although.. i don't really see the need to expose `prelude.inc` outside of the package. So I guess removing "install-includes" entirely plus per-component "include-dirs" is the way to go?
hvr commented 2018-11-12 22:11:13 +01:00 (Migrated from github.com)

@lspitzner

So I guess removing "install-includes" entirely plus per-component "include-dirs" is the way to go?

Sorry for the late response. Yes, that sounds even better!

@lspitzner > So I guess removing "install-includes" entirely plus per-component "include-dirs" is the way to go? Sorry for the late response. Yes, that sounds even better!
lspitzner commented 2018-11-30 00:32:20 +01:00 (Migrated from github.com)

Should be fixed on master. At least I managed to get new-install to work once with the change in 784e4d0; it still does not like to overwrite existing symlinks it seems, and generally creates symlinks regardless of whether the build succeeded. When in doubt, delete existing symlink and look at verbose build output.

If this is confirmed to work we probably want a note in the README for this, too.

Should be fixed on master. At least I managed to get new-install to work once with the change in 784e4d0; it still does not like to overwrite existing symlinks it seems, and generally creates symlinks regardless of whether the build succeeded. When in doubt, delete existing symlink and look at verbose build output. If this is confirmed to work we probably want a note in the README for this, too.
hvr commented 2018-11-30 01:07:56 +01:00 (Migrated from github.com)

@lspitzner Have you tried w/ the latest cabal 2.4.1.0 release? that one shouldn't create symlinks on failure and be less silent about the failure, e.g.:

$ /opt/cabal/2.4/bin/cabal v2-install brittany
Warning: Parsing the index cache failed (Unknown encoding for constructor).
Trying to regenerate the index cache...
Resolving dependencies...
Build profile: -w ghc-8.4.4 -O1
In order, the following will be built (use -v for more details):
 - brittany-0.11.0.0 (exe:brittany) (requires build)
Starting     brittany-0.11.0.0 (exe:brittany)
Building     brittany-0.11.0.0 (exe:brittany)
Warning: Some package(s) failed to build. Try rerunning with -j1 if you can't see the error.
@lspitzner Have you tried w/ the latest cabal 2.4.1.0 release? that one shouldn't create symlinks on failure and be less silent about the failure, e.g.: ``` $ /opt/cabal/2.4/bin/cabal v2-install brittany Warning: Parsing the index cache failed (Unknown encoding for constructor). Trying to regenerate the index cache... Resolving dependencies... Build profile: -w ghc-8.4.4 -O1 In order, the following will be built (use -v for more details): - brittany-0.11.0.0 (exe:brittany) (requires build) Starting brittany-0.11.0.0 (exe:brittany) Building brittany-0.11.0.0 (exe:brittany) Warning: Some package(s) failed to build. Try rerunning with -j1 if you can't see the error. ```
andreabedini commented 2019-09-04 07:37:35 +02:00 (Migrated from github.com)

I just tested with cabal-install 3.0.0.0 (compiled using the same version of the cabal library)

Installing   brittany-0.12.0.0 (exe:brittany)
Completed    brittany-0.12.0.0 (exe:brittany)
cabal: installdir is not defined. Set it in your cabal config file or use
--installdir=<path>

passing installdir works correctly.

[~] cabal install brittany --installdir=$HOME/bin
Resolving dependencies...
Up to date
Symlinking 'brittany'
[~] brittany --version
brittany version 0.12.0.0
Copyright (C) 2016-2018 Lennart Spitzner
There is NO WARRANTY, to the extent permitted by law.

Good work everyone! ❤️

I just tested with cabal-install 3.0.0.0 (compiled using the same version of the cabal library) ``` Installing brittany-0.12.0.0 (exe:brittany) Completed brittany-0.12.0.0 (exe:brittany) cabal: installdir is not defined. Set it in your cabal config file or use --installdir=<path> ``` passing `installdir` works correctly. ``` [~] cabal install brittany --installdir=$HOME/bin Resolving dependencies... Up to date Symlinking 'brittany' [~] brittany --version brittany version 0.12.0.0 Copyright (C) 2016-2018 Lennart Spitzner There is NO WARRANTY, to the extent permitted by law. ``` Good work everyone! :heart:
andreabedini commented 2019-09-04 07:46:20 +02:00 (Migrated from github.com)

I just realised installdir is not defined is because I didn't update .cabal/config to version 3 (not that I was told to :P)

I just realised `installdir is not defined` is because I didn't update `.cabal/config` to version 3 (not that I was told to :P)
😆 1
lspitzner commented 2019-09-04 11:38:56 +02:00 (Migrated from github.com)

Thanks for confirming @andreabedini

The README was very recently updated to mention that flag. Will be in the next release.

Thanks for confirming @andreabedini The README was very recently updated to mention that flag. Will be in the next release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
ghc92
master
ChickenProp/promoted-type-applications
felixonmars/patch-1
mxxun/ghc-9.2
prikhi/add-alternative-coreio
eborden/eborden/sum-data
imports-sorted
api
stablename
0.13.1.2
0.13.1.1
0.13.1.0
0.13.0.0
0.12.2.0
0.12.1.1.x2
0.12.1.1.x1
0.12.1.1
0.12.1.0
0.12.0.0
0.11.0.0.x2
0.11.0.0.x1
0.11.0.0
0.10.0.0
0.9.0.1
0.9.0.0
0.8.0.3
0.8.0.2
0.7.1.0
0.7.0.0
0.6.0.0
0.5.0.0
0.4.0.0
0.3.0.0
0.2.0.0
Labels
Clear labels   
blocked: dependency
   
blocked: info-needed
   
bug
   
duplicate
   
enhancement
   
fixed in HEAD
   
help wanted
   
hs:arrows
   
hs:brackets
   
hs:classes
   
hs:comments
   
hs:do-notation
   
hs:guards
   
hs:lists
   
hs:operators
   
hs:patterns
   
hs:records
   
hs:types
   
invalid
   
language extension support
   
layouting
   
needs confirmation
   
priority: high
   
priority: low
   
question
   
revisit before next release
   
wontfix
No Label
blocked: dependency
blocked: info-needed
bug
duplicate
enhancement
fixed in HEAD
help wanted
hs:arrows
hs:brackets
hs:classes
hs:comments
hs:do-notation
hs:guards
hs:lists
hs:operators
hs:patterns
hs:records
hs:types
invalid
language extension support
layouting
needs confirmation
priority: high
priority: low
question
revisit before next release
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#162
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?