Parsing error on comments on type definition within instance declaration #282

New Issue

2020-02-14T19:11:06+01:00

cbeav commented

2020-02-14 19:11:06 +01:00

(Migrated from github.com)

I noticed an issue with brittany's comment parsing in the following:

instance HasDependencies SomeDataModel where
  -- N.B. Here is a bunch of explanatory context about the relationship
  -- between these data models or whatever.
  type Dependencies SomeDataModel
    = ( SomeOtherDataModelId
      , SomeOtherOtherDataModelId
      )

@eborden mentioned I should drop an issue here and that this should be an easy case to add a test for and address. Let me know if you need any help reproducing!

FWIW, I just skirted the issue by promoting the comment to be outside of the instance declaration. Not a high priority fix for me or else I'd probably dive in :) Just wanted to make sure it was tracked somewhere.

I noticed an issue with `brittany`'s comment parsing in the following: ```haskell instance HasDependencies SomeDataModel where -- N.B. Here is a bunch of explanatory context about the relationship -- between these data models or whatever. type Dependencies SomeDataModel = ( SomeOtherDataModelId , SomeOtherOtherDataModelId ) ``` @eborden mentioned I should drop an issue here and that this should be an easy case to add a test for and address. Let me know if you need any help reproducing! FWIW, I just skirted the issue by promoting the comment to be outside of the `instance` declaration. Not a high priority fix for me or else I'd probably dive in :) Just wanted to make sure it was tracked somewhere.

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#282