Support GHC 9.0 #356

2021-10-20T14:04:33+02:00

tfausak commented

2021-10-20 14:04:33 +02:00

(Migrated from github.com)

This will fix #352, but it's very much a work in progress.

tfausak (Migrated from github.com) reviewed 2021-10-20 14:10:38 +02:00

stack.yaml

tfausak (Migrated from github.com) commented

2021-10-20 14:10:38 +02:00

czipwith fails to build because of changes to template-haskell:

czipwith> /tmp/stack-7a145276237e5cc0/czipwith-1.0.1.3/src/Data/CZipWith.hs:226:13: error:
czipwith>     • The constructor ‘PlainTV’ should have 2 arguments, but has been given 1
czipwith>     • In the pattern: PlainTV n
czipwith>       In a case alternative: PlainTV n -> n
czipwith>       In the expression:
czipwith>         case _tyvarbnd of
czipwith>           PlainTV n -> n
czipwith>           KindedTV n _ -> n
czipwith>     |       
czipwith> 226 |             PlainTV n    -> n
czipwith>     |             ^^^^^^^^^

`czipwith` fails to build because of changes to `template-haskell`: ``` czipwith> /tmp/stack-7a145276237e5cc0/czipwith-1.0.1.3/src/Data/CZipWith.hs:226:13: error: czipwith> • The constructor ‘PlainTV’ should have 2 arguments, but has been given 1 czipwith> • In the pattern: PlainTV n czipwith> In a case alternative: PlainTV n -> n czipwith> In the expression: czipwith> case _tyvarbnd of czipwith> PlainTV n -> n czipwith> KindedTV n _ -> n czipwith> | czipwith> 226 | PlainTV n -> n czipwith> | ^^^^^^^^^ ```

jneira commented

2021-10-20 14:11:48 +02:00

(Migrated from github.com)

Many thanks for take care, imagining how cumbersome is to have to keep up to date all these packages

tfausak (Migrated from github.com) reviewed 2021-10-20 14:14:03 +02:00

stack.yaml

tfausak (Migrated from github.com) commented

2021-10-20 14:14:03 +02:00

Ah, that was easy 😄 https://github.com/lspitzner/czipwith/pull/2

tfausak commented

2021-10-29 02:16:31 +02:00

(Migrated from github.com)

I quickly ran out of easy stuff to fix here. I must say, I'm a bit out of my depth here. Supporting GHC 9 feels possible to me, but maintaining support for earlier versions will be a challenge. I don't normally use CPP, and there are lots of little changes to paper over. Perhaps this should use ghc-lib-parser, but I think that would require changing ghc-exactprint?

I quickly ran out of easy stuff to fix here. I must say, I'm a bit out of my depth here. Supporting GHC 9 feels possible to me, but maintaining support for earlier versions will be a challenge. I don't normally use CPP, and there are lots of little changes to paper over. Perhaps this should use `ghc-lib-parser`, but I think that would require changing `ghc-exactprint`?

tfausak commented

2021-10-29 21:14:53 +02:00

(Migrated from github.com)

GHC 9.2 was just released: https://discourse.haskell.org/t/ghc-9-2-1-released/3527

👍 1

tfausak commented

2021-10-30 01:17:15 +02:00

(Migrated from github.com)

@jneira: Question for you about HLS integration: Does Brittany need to support all the same versions of HLS in order to be bundled with it? I would much rather support a single version of GHC and provide static binaries if that's possible.

jneira commented

2021-10-30 14:58:24 +02:00

(Migrated from github.com)

I am afraid that is the case, each hls version is shipped for each supported ghc.

tfausak commented

2021-11-06 22:56:06 +01:00

(Migrated from github.com)

Closing this in favor of #357.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#356