Type application with Nats or Symbols upsets let alignment #48

New Issue

2017-08-15T10:59:07+02:00

expipiplus1 commented

2017-08-15 10:59:07 +02:00

(Migrated from github.com)

Compare:

foo =
  let a = b @1
      cccc = ()
  in  foo

foo =
  let a = b @""
      cccc = ()
  in  foo

foo =
  let a    = b @d
      cccc = ()
  in  foo

foo =
  let a    = b @D
      cccc = ()
  in  foo

Compare: ```haskell foo = let a = b @1 cccc = () in foo foo = let a = b @"" cccc = () in foo foo = let a = b @d cccc = () in foo foo = let a = b @D cccc = () in foo ```

lspitzner commented

2017-08-15 12:25:04 +02:00

(Migrated from github.com)

Right, this most likely comes down to this case lacking a proper implementation. Although I am a bit confused why it does not work as-is; how layoutByExact works but inhibits alignment.. will investigate ~~later~~ next weekend.

Right, this most likely comes down to [this case lacking a proper implementation](https://github.com/lspitzner/brittany/blob/ebf84a03e939ad1017cc741339d0ec7e4080e776/src/Language/Haskell/Brittany/Internal/Layouters/Type.hs#L602-L603). Although I am a bit confused why it does not work as-is; how `layoutByExact` works but inhibits alignment.. will investigate ~~later~~ next weekend.

lspitzner commented

2017-08-20 13:18:26 +02:00

(Migrated from github.com)

Fixed on dev branch

Fixed on `dev` branch

expipiplus1 commented

2017-08-20 13:21:14 +02:00

(Migrated from github.com)

Thanks!

On Sun, 20 Aug 2017, 12:18 pm Lennart Spitzner notifications@github.com
wrote:

Fixed on dev branch

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lspitzner/brittany/issues/48#issuecomment-323578698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0U3LVIBP6WX1oETO3GDNoTd_DupU7Tks5saBYDgaJpZM4O3WZv
.

Thanks! On Sun, 20 Aug 2017, 12:18 pm Lennart Spitzner <notifications@github.com> wrote: > Fixed on dev branch > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lspitzner/brittany/issues/48#issuecomment-323578698>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA0U3LVIBP6WX1oETO3GDNoTd_DupU7Tks5saBYDgaJpZM4O3WZv> > . >

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#48