Consolidate record expression layouter #184

2018-09-16T21:55:35+02:00

eborden commented

2018-09-16 21:55:35 +02:00

(Migrated from github.com)

Both record construction and update layouting have very similar
constructions. These each had their own layouter with slightly different
variations. Variations here lead to subtly different bugs in layout for
nearly identical syntactic forms.

The record update logic is more advanced and respects IndentPolicyLeft.
Instead of keeping these layouters distinct we can consolidate
construction logic into the update logic. This results in a smaller
volume of code and more uniform layouting of syntax for these similar
forms.

Record constructors with fields and wildcards are not included in this
consolidation. A TODO has been left to handle this consolidation later.

This fixes https://github.com/lspitzner/brittany/issues/176

Both record construction and update layouting have very similar constructions. These each had their own layouter with slightly different variations. Variations here lead to subtly different bugs in layout for nearly identical syntactic forms. The record update logic is more advanced and respects `IndentPolicyLeft`. Instead of keeping these layouters distinct we can consolidate construction logic into the update logic. This results in a smaller volume of code and more uniform layouting of syntax for these similar forms. Record constructors with fields and wildcards are not included in this consolidation. A `TODO` has been left to handle this consolidation later. This fixes https://github.com/lspitzner/brittany/issues/176

🎉 1

lspitzner commented

2018-09-17 23:40:55 +02:00

(Migrated from github.com)

thanks!

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#184