hexagoxel
/
brittany
1
0
Fork 0
Code Issues 117 Pull Requests 5 Packages Projects Releases 5 Wiki Activity

Add support for GHC 8.10.1 #312

Closed
bubba wants to merge 6 commits from ghc-8.10.1 into master
pull from: ghc-8.10.1
merge into: hexagoxel:master
Conversation 8 Commits 6 Files Changed 17
bubba commented 2020-08-06 22:38:25 +02:00 (Migrated from github.com)

Continuing the work of @jneira in #305 , rebased

Continuing the work of @jneira in #305 , rebased
👍 2
codygman commented 2020-09-15 17:35:53 +02:00 (Migrated from github.com)

Related to #269

Related to #269
tfausak commented 2020-11-15 16:55:51 +01:00 (Migrated from github.com)

This doesn't build with GHC 8.4, 8.2, or 8.0. Do you know if it's an easy fix or not?

This doesn't build with GHC 8.4, 8.2, or 8.0. Do you know if it's an easy fix or not? - 8.4: https://github.com/lspitzner/brittany/pull/324/checks?check_run_id=1402854550 - 8.2: https://github.com/lspitzner/brittany/pull/324/checks?check_run_id=1402854557 - 8.0: https://github.com/lspitzner/brittany/pull/324/checks?check_run_id=1402854564
jneira commented 2020-11-16 08:53:51 +01:00 (Migrated from github.com)

@tfausak maybe i am not interpreting those builds correctly but they seem fail for ghc-8.10.2 and no for other versions??

EDIT: oh, i've just see you dropped support for those versions in the pr

@tfausak maybe i am not interpreting those builds correctly but they seem fail for ghc-8.10.2 and no for other versions?? EDIT: oh, i've just see you dropped support for those versions in the pr
jneira commented 2020-11-16 08:58:56 +01:00 (Migrated from github.com)

Afaics all changes in this pr was made under cpp conditions so it should not interfere with older ghc versions (module some error)

Afaics all changes in this pr was made under cpp conditions so it should not interfere with older ghc versions (module some error)
tfausak commented 2020-11-16 13:39:19 +01:00 (Migrated from github.com)

I think some of the CPP changes looked like this:

# if MIN_VERSION_ghc(8, 10, 1)
-- nothing
# else
some existing code
# endif
I think some of the CPP changes looked like this: ``` hs # if MIN_VERSION_ghc(8, 10, 1) -- nothing # else some existing code # endif ```
jneira (Migrated from github.com) reviewed 2020-11-16 13:47:32 +01:00
src/Language/Haskell/Brittany/Internal/Layouters/Expr.hs
jneira (Migrated from github.com) commented 2020-11-16 13:47:32 +01:00

cpp if branch without code

cpp if branch without code
jneira (Migrated from github.com) reviewed 2020-11-16 13:47:48 +01:00
src/Language/Haskell/Brittany/Internal/Layouters/Expr.hs
jneira (Migrated from github.com) commented 2020-11-16 13:47:48 +01:00

cpp if branch without code

cpp if branch without code
jneira commented 2020-11-16 13:51:18 +01:00 (Migrated from github.com)

Yeah, but it should no make fail previous ghc versions but make ghc-8.10.1 fail, no?
(sorry if i am wrong i am only gathering at the code without even compiling it)

Can you share the errors that were thrown for earlier versions? are there in the travis failed build for this pr?

Yeah, but it should no make fail previous ghc versions but make ghc-8.10.1 fail, no? (sorry if i am wrong i am only gathering at the code without even compiling it) Can you share the errors that were thrown for earlier versions? are there in the travis failed build for this pr?
tfausak commented 2020-11-16 13:57:20 +01:00 (Migrated from github.com)

Sorry, my comment wasn't very helpful. Also apparently the links I shared earlier don't work anymore. I probably shouldn't have rebased #324. Here are actually usable links to the build failures:

Sorry, my comment wasn't very helpful. Also apparently the links I shared earlier don't work anymore. I probably shouldn't have rebased #324. Here are actually usable links to the build failures: - 8.4: https://github.com/lspitzner/brittany/runs/1402854550 - 8.2: https://github.com/lspitzner/brittany/runs/1402854557 - 8.0: https://github.com/lspitzner/brittany/runs/1402854564
👍 1
tfausak commented 2020-11-23 14:10:47 +01:00 (Migrated from github.com)

I'm closing this in favor of #324, which includes these commits. Please let me know if I've missed something!

I'm closing this in favor of #324, which includes these commits. Please let me know if I've missed something!
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked: dependency
   
blocked: info-needed
   
bug
   
duplicate
   
enhancement
   
fixed in HEAD
   
help wanted
   
hs:arrows
   
hs:brackets
   
hs:classes
   
hs:comments
   
hs:do-notation
   
hs:guards
   
hs:lists
   
hs:operators
   
hs:patterns
   
hs:records
   
hs:types
   
invalid
   
language extension support
   
layouting
   
needs confirmation
   
priority: high
   
priority: low
   
question
   
revisit before next release
   
wontfix
No Label
blocked: dependency
blocked: info-needed
bug
duplicate
enhancement
fixed in HEAD
help wanted
hs:arrows
hs:brackets
hs:classes
hs:comments
hs:do-notation
hs:guards
hs:lists
hs:operators
hs:patterns
hs:records
hs:types
invalid
language extension support
layouting
needs confirmation
priority: high
priority: low
question
revisit before next release
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#312
There is no content yet.
Delete Branch "ghc-8.10.1"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?