nondecreasing export list formatting #313

2020-08-28T03:49:19+02:00

expipiplus1 commented

2020-08-28 03:49:19 +02:00

(Migrated from github.com)

module Foo
  ( bar
  , baz
  )
where

now becomes

module Foo
  ( bar
  , baz
  ) where

Having the where aligned with module is a bit weirdy IMO.

Not sure if my patch is the best way to do this, I wrote it a while ago
and have forgotten how much care I put into it.

~Haven't updated the tests yet either, but is this something which would
be merged?~

```haskell module Foo ( bar , baz ) where ``` now becomes ```haskell module Foo ( bar , baz ) where ``` Having the `where` aligned with `module` is a bit weirdy IMO. Not sure if my patch is the best way to do this, I wrote it a while ago and have forgotten how much care I put into it. ~Haven't updated the tests yet either, but is this something which would be merged?~

lspitzner (Migrated from github.com) reviewed 2020-08-28 03:49:19 +02:00

tfausak commented

2020-08-28 22:15:41 +02:00

(Migrated from github.com)

Looks good to me! I've always wondered by Brittany formats exports lists like this in the first place.

expipiplus1 commented

2020-10-18 09:09:33 +02:00

(Migrated from github.com)

Is it possible to get this merged, please?

tfausak commented

2020-10-20 22:35:18 +02:00

(Migrated from github.com)

Sure, I'll go ahead and merge this.

expipiplus1 commented

2020-10-21 02:59:44 +02:00

(Migrated from github.com)

Thanks!

On Wed, Oct 21, 2020, 4:35 AM Taylor Fausak notifications@github.com
wrote:

Merged #313 https://github.com/lspitzner/brittany/pull/313 into master.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lspitzner/brittany/pull/313#event-3900685005, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRJXGJWLBBEDSVJBZPQVDSLXYBXANCNFSM4QNTQNOA
.

Thanks! On Wed, Oct 21, 2020, 4:35 AM Taylor Fausak <notifications@github.com> wrote: > Merged #313 <https://github.com/lspitzner/brittany/pull/313> into master. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lspitzner/brittany/pull/313#event-3900685005>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGRJXGJWLBBEDSVJBZPQVDSLXYBXANCNFSM4QNTQNOA> > . >

Sign in to join this conversation.

No reviewers

lspitzner

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#313