Simplify Nix expressions #329

Merged
expipiplus1 merged 1 commits from joe-nix into master 2020-12-11 14:08:17 +01:00
expipiplus1 commented 2020-12-10 05:12:29 +01:00 (Migrated from github.com)

This uses developPackage from nixpkgs to generate the derivation

Also add CI for nix build

This uses `developPackage` from `nixpkgs` to generate the derivation Also add CI for nix build
expipiplus1 commented 2020-12-10 05:13:06 +01:00 (Migrated from github.com)
reopened from https://github.com/lspitzner/brittany/pull/326#event-4092913743
tfausak (Migrated from github.com) approved these changes 2020-12-10 14:47:29 +01:00
tfausak (Migrated from github.com) left a comment

I am not a Nix wizard but this does indeed look like an improvement. Thanks!

I am not a Nix wizard but this does indeed look like an improvement. Thanks!
tfausak (Migrated from github.com) commented 2020-12-10 14:47:12 +01:00

Should this have name = "brittany", or does it not matter?

Should this have `name = "brittany"`, or does it not matter?
expipiplus1 (Migrated from github.com) reviewed 2020-12-11 10:03:14 +01:00
expipiplus1 (Migrated from github.com) commented 2020-12-11 10:03:14 +01:00

It doesn't really matter, in this case it'll use the enclosing directory name. However it should be "brittany" to make sure the same derivation is generated regardless of the directory name. Fixed.

It doesn't *really* matter, in this case it'll use the enclosing directory name. However it should be "brittany" to make sure the same derivation is generated regardless of the directory name. Fixed.
expipiplus1 commented 2020-12-12 02:17:09 +01:00 (Migrated from github.com)

Thanks!

On Fri, Dec 11, 2020, 9:08 PM Taylor Fausak notifications@github.com
wrote:

Merged #329 https://github.com/lspitzner/brittany/pull/329 into master.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lspitzner/brittany/pull/329#event-4100288074, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRJXDY63RLHBAD5Q7SC6DSUIKVBANCNFSM4UUOCR5Q
.

Thanks! On Fri, Dec 11, 2020, 9:08 PM Taylor Fausak <notifications@github.com> wrote: > Merged #329 <https://github.com/lspitzner/brittany/pull/329> into master. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lspitzner/brittany/pull/329#event-4100288074>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGRJXDY63RLHBAD5Q7SC6DSUIKVBANCNFSM4UUOCR5Q> > . >
Sign in to join this conversation.
There is no content yet.