Unboxed tuples #186

2018-09-18T01:32:20+02:00

sergv commented

2018-09-18 01:32:20 +02:00

(Migrated from github.com)

I noticed that indenting snipptes like

case foo# of
  (# bar#, baz# #) -> ...

will produce output like

case foo# of
  (#bar#, baz##) -> ...

which is invalid. I decided to put spaces around delimiters in (#...#) unconditionally to avoid having to check whether names have hashes. This style also seems more prevalent from my non-representative sample.

I also enabled running literate tests in parallel on my machine and though it could be useful for others. Please let me know what you thing about using all available cores to run the tests.

I noticed that indenting snipptes like ```haskell case foo# of (# bar#, baz# #) -> ... ``` will produce output like ```haskell case foo# of (#bar#, baz##) -> ... ``` which is invalid. I decided to put spaces around delimiters in `(#...#)` unconditionally to avoid having to check whether names have hashes. This style also seems more prevalent from my non-representative sample. I also enabled running literate tests in parallel on my machine and though it could be useful for others. Please let me know what you thing about using all available cores to run the tests.

👍 1

ElvishJerricco commented

2018-09-18 06:41:17 +02:00

(Migrated from github.com)

I think doing this unconditionally is pretty common style anyway, so I think this is a good change

lspitzner commented

2018-09-23 23:40:30 +02:00

(Migrated from github.com)

Thanks! I agree that it makes sense to consistently use spaces for unboxed tuples.

I have pushed another commit with minor cleanups. Should be ready to merge.

Regarding the parallel testing, I am a bit confused about the failing test. The failure indicates a performance issue (and might be due to heavy load on travis) but then it is for a testsuite that you did not even touch. Plus it is only new-build that is failing, so I wonder if new-build is just somehow picking up the flag or running entire suits in parallel or something. Maybe I have to force serial test execution via -j1 for new-build on travis? If all that does not work I might prefer to revert that bit, but let's see first.

Thanks! I agree that it makes sense to consistently use spaces for unboxed tuples. I have pushed another commit with minor cleanups. Should be ready to merge. Regarding the parallel testing, I am a bit confused about the failing test. The failure indicates a performance issue (and might be due to heavy load on travis) but then it is for a testsuite that you did not even touch. Plus it is only new-build that is failing, so I wonder if new-build is just somehow picking up the flag or running entire suits in parallel or something. Maybe I have to force serial test execution via `-j1` for new-build on travis? If all that does not work I might prefer to revert that bit, but let's see first.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#186