Sorted imports 2 #325

2020-11-20T16:08:15+01:00

expipiplus1 commented

2020-11-20 16:08:15 +01:00

(Migrated from github.com)

I've merged the ghc 8.10 branch against the sorted-import branch and added some basic tests (Had to add a blank line function to the test suite)

I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?!

(I've targeted this against the ghc-8.10 branch because it includes those commits too)

The only required checklist items on @lspitzner's PR were:

tests (I'm not sure if these ones here are sufficient)
testing on a large codebase (I've been running this daily for ages without any issues whatsoever (including on some very large codebases))

I've merged the ghc 8.10 branch against the sorted-import branch and added some basic tests (Had to add a blank line function to the test suite) I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?! (I've targeted this against the ghc-8.10 branch because it includes those commits too) The only required checklist items on @lspitzner's PR were: - tests (I'm not sure if these ones here are sufficient) - testing on a large codebase (I've been running this daily for ages without any issues whatsoever (including on some very large codebases))

expipiplus1 commented

2020-12-09 05:23:15 +01:00

(Migrated from github.com)

If this were to be gated behind a configuration option could this be merged? Or ideally just merged anyway

I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?!

Would be good to get an answer to this too if possible.

If this were to be gated behind a configuration option could this be merged? Or ideally just merged anyway > I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?! Would be good to get an answer to this too if possible.

tfausak commented

2020-12-10 03:52:13 +01:00

(Migrated from github.com)

Sorry, I didn't mean to close this. I thought GitHub was supposed to rebase PRs when you delete a branch. Please re-open this against the master branch. Thanks!

Sorry, I didn't mean to close this. I thought GitHub was supposed to rebase PRs when you delete a branch. Please re-open this against the `master` branch. Thanks!

👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#325