hexagoxel
/
brittany
1
0
Fork 0
Code Issues 117 Pull Requests 5 Packages Projects Releases 5 Wiki Activity

Sorted imports 2 #330

Merged
expipiplus1 merged 11 commits from imports-sorted into master 2020-12-11 16:44:33 +01:00
Conversation 2 Commits 11 Files Changed 12
expipiplus1 commented 2020-12-10 05:14:17 +01:00 (Migrated from github.com)

I've merged the ghc 8.10 branch against the sorted-import branch and added some basic tests (Had to add a blank line function to the test suite)

I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?!

(I've targeted this against the ghc-8.10 branch because it includes those commits too)

The only required checklist items on @lspitzner's PR were:

  • tests (I'm not sure if these ones here are sufficient)
  • testing on a large codebase (I've been running this daily for ages without any issues whatsoever (including on some very large codebases))

(reopened from https://github.com/lspitzner/brittany/pull/325)

I've merged the ghc 8.10 branch against the sorted-import branch and added some basic tests (Had to add a blank line function to the test suite) I'm not sure if I'm being dense, but are there any tests where one enters the initial and expected source files, or is every test a "passthrough" test. i.e. would the identity function pass the testsuite?! (I've targeted this against the ghc-8.10 branch because it includes those commits too) The only required checklist items on @lspitzner's PR were: - tests (I'm not sure if these ones here are sufficient) - testing on a large codebase (I've been running this daily for ages without any issues whatsoever (including on some very large codebases)) (reopened from https://github.com/lspitzner/brittany/pull/325)
tfausak (Migrated from github.com) reviewed 2020-12-10 14:53:21 +01:00
src-literatetests/30-tests-context-free.blt
tfausak (Migrated from github.com) commented 2020-12-10 14:49:12 +01:00

😆 These are funny now that they're sorted.

😆 These are funny now that they're sorted.
src/Language/Haskell/Brittany/Internal/Layouters/IE.hs
tfausak (Migrated from github.com) commented 2020-12-10 14:52:19 +01:00

We can drop this CPP now.

We can drop this CPP now.
tfausak (Migrated from github.com) commented 2020-12-10 14:52:26 +01:00

Same with this.

Same with this.
src/Language/Haskell/Brittany/Internal/Layouters/IE.hs
@ -150,0 +190,4 @@
$ docSeq
$ [docLit (Text.pack "(")]
++ (docForceSingleline <$> ieDs)
++ [docParenR]
tfausak (Migrated from github.com) commented 2020-12-10 14:52:41 +01:00

And this.

And this.
tfausak (Migrated from github.com) commented 2020-12-10 14:52:48 +01:00

And this.

And this.
expipiplus1 (Migrated from github.com) reviewed 2020-12-11 10:06:57 +01:00
src-literatetests/30-tests-context-free.blt
expipiplus1 (Migrated from github.com) commented 2020-12-11 10:06:57 +01:00

If you can think of an alphabetical sentence with the same meaning we should use that!

If you can think of an alphabetical sentence with the same meaning we should use that!
expipiplus1 (Migrated from github.com) reviewed 2020-12-11 10:09:03 +01:00
src/Language/Haskell/Brittany/Internal/Layouters/IE.hs
@ -150,0 +190,4 @@
$ docSeq
$ [docLit (Text.pack "(")]
++ (docForceSingleline <$> ieDs)
++ [docParenR]
expipiplus1 (Migrated from github.com) commented 2020-12-11 10:09:02 +01:00

done

done
expipiplus1 (Migrated from github.com) reviewed 2020-12-11 10:09:05 +01:00
src/Language/Haskell/Brittany/Internal/Layouters/IE.hs
@ -150,0 +190,4 @@
$ docSeq
$ [docLit (Text.pack "(")]
++ (docForceSingleline <$> ieDs)
++ [docParenR]
expipiplus1 (Migrated from github.com) commented 2020-12-11 10:09:05 +01:00

done

done
expipiplus1 (Migrated from github.com) reviewed 2020-12-11 10:09:08 +01:00
src/Language/Haskell/Brittany/Internal/Layouters/IE.hs
expipiplus1 (Migrated from github.com) commented 2020-12-11 10:09:08 +01:00

done

done
tfausak commented 2020-12-11 14:10:25 +01:00 (Migrated from github.com)

are there any tests where one enters the initial and expected source files

Not that I know of, but it seems like there should be!

> are there any tests where one enters the initial and expected source files Not that I know of, but it seems like there should be!
tfausak (Migrated from github.com) approved these changes 2020-12-11 16:44:19 +01:00
tfausak (Migrated from github.com) left a comment

I can't really speak to the code, but the result (sorting imports) looks great! Thanks for sticking with this and getting it over the line.

I can't really speak to the code, but the result (sorting imports) looks great! Thanks for sticking with this and getting it over the line.
expipiplus1 commented 2020-12-12 02:17:34 +01:00 (Migrated from github.com)

Thanks!

On Fri, Dec 11, 2020, 11:44 PM Taylor Fausak notifications@github.com
wrote:

Merged #330 https://github.com/lspitzner/brittany/pull/330 into master.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lspitzner/brittany/pull/330#event-4100998213, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRJXGIFKP575X6AWALH3LSUI47JANCNFSM4UUOEFFQ
.

Thanks! On Fri, Dec 11, 2020, 11:44 PM Taylor Fausak <notifications@github.com> wrote: > Merged #330 <https://github.com/lspitzner/brittany/pull/330> into master. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lspitzner/brittany/pull/330#event-4100998213>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGRJXGIFKP575X6AWALH3LSUI47JANCNFSM4UUOEFFQ> > . >
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
tfausak
Labels
Clear labels   
blocked: dependency
   
blocked: info-needed
   
bug
   
duplicate
   
enhancement
   
fixed in HEAD
   
help wanted
   
hs:arrows
   
hs:brackets
   
hs:classes
   
hs:comments
   
hs:do-notation
   
hs:guards
   
hs:lists
   
hs:operators
   
hs:patterns
   
hs:records
   
hs:types
   
invalid
   
language extension support
   
layouting
   
needs confirmation
   
priority: high
   
priority: low
   
question
   
revisit before next release
   
wontfix
No Label
blocked: dependency
blocked: info-needed
bug
duplicate
enhancement
fixed in HEAD
help wanted
hs:arrows
hs:brackets
hs:classes
hs:comments
hs:do-notation
hs:guards
hs:lists
hs:operators
hs:patterns
hs:records
hs:types
invalid
language extension support
layouting
needs confirmation
priority: high
priority: low
question
revisit before next release
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#330
There is no content yet.
Delete Branch "imports-sorted"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?