Release current master? #318

New Issue

2020-10-21T19:53:11+02:00

andys8 commented

2020-10-21 19:53:11 +02:00

(Migrated from github.com)

Hi :)

I noticed there are features and bugfixes on master that aren't released.

https://github.com/lspitzner/brittany/compare/0.12.1.1.x2...master

formatting data
module .. where
support for pattern synonyms

If https://github.com/lspitzner/brittany/issues/47 isn't partially implemented and could lead to issues, one could consider releasing the current state as is. I ran it on a code base and the changes it produces seem to improve things (mainly because data is formatted).

Hi :) I noticed there are features and bugfixes on `master` that aren't released. https://github.com/lspitzner/brittany/compare/0.12.1.1.x2...master * formatting `data` * `module .. where` * support for pattern synonyms If https://github.com/lspitzner/brittany/issues/47 isn't partially implemented and could lead to issues, one could consider releasing the current state as is. I ran it on a code base and the changes it produces seem to improve things (mainly because `data` is formatted).

tfausak commented

2020-10-21 20:23:07 +02:00

(Migrated from github.com)

I technically have permission to do this, but I haven't done it before and I don't know the exact process.

📟 @lspitzner @eborden

I technically have permission to do this, but I haven't done it before and I don't know the exact process. :pager: @lspitzner @eborden

👍 3

arybczak commented

2020-10-29 10:37:40 +01:00

(Migrated from github.com)

Seconded. Can we please get a release with #312 merged?

vaclavsvejcar commented

2020-11-02 11:04:37 +01:00

(Migrated from github.com)

It would be really awesome. As a workaround I ended up building own versions from master.

maralorn commented

2020-11-10 21:08:48 +01:00

(Migrated from github.com)

I‘d like to emphasize the need for this. Recent releases of haskell-language-server are not compatible with the last released brittany version. (at least I think so, because they switched to using @bubba's branch). And there are plans to release hls to hackage soon.

Making a small minor release of brittany would be great to help with packaging hls downstream. (i.e. right now we maintain two different brittanies in nixpkgs.)

EDIT: Oh, I am sorry for the noise. I realized, that they use a branch with not upstreamed changes for 8.10 compatibility.

I‘d like to emphasize the need for this. Recent releases of haskell-language-server are not compatible with the last released brittany version. (at least I think so, because they switched to using @bubba's branch). And there are plans to release hls to hackage soon. Making a small minor release of brittany would be great to help with packaging hls downstream. (i.e. right now we maintain two different brittanies in nixpkgs.) EDIT: Oh, I am sorry for the noise. I realized, that they use a branch with not upstreamed changes for 8.10 compatibility.

👍 1

expipiplus1 commented

2020-11-12 14:44:32 +01:00

(Migrated from github.com)

@tfausak I think you should just bite the bullet and go ahead, what's the worst that can happen, a version has to be marked deprecated on Hackage?

arybczak commented

2020-11-12 17:49:53 +01:00

(Migrated from github.com)

Indeed, perfectionism leads to inaction. Please release the master + #312 🙏

Indeed, perfectionism leads to inaction. Please release the master + #312 :pray:

tfausak commented

2020-11-15 18:55:03 +01:00

(Migrated from github.com)

I have built and released the current master branch as version 0.12.2.0.

https://hackage.haskell.org/package/brittany-0.12.2.0
https://github.com/lspitzner/brittany/releases/tag/0.12.2.0 (includes binaries)

I didn't merge #312 because the build failed with GHC < 8.8 and the tests failed with GHC 8.10. If you'd like to help, please see #324.

I didn't update the demo site (https://hexagoxel.de/brittany/) because I don't know how.

I have built and released the current master branch as version 0.12.2.0. - https://hackage.haskell.org/package/brittany-0.12.2.0 - https://github.com/lspitzner/brittany/releases/tag/0.12.2.0 (includes binaries) I didn't merge #312 because the build failed with GHC < 8.8 and the tests failed with GHC 8.10. If you'd like to help, please see #324. I didn't update the demo site (https://hexagoxel.de/brittany/) because I don't know how.

🎉 1

expipiplus1 commented

2020-11-16 01:51:54 +01:00

(Migrated from github.com)

Thanks!

On Mon, Nov 16, 2020, 1:56 AM Taylor Fausak notifications@github.com
wrote:

I have built and released the current master branch as version 0.12.2.0.

https://hackage.haskell.org/package/brittany-0.12.2.0

https://github.com/lspitzner/brittany/releases/tag/0.12.2.0
(includes binaries)

I didn't merge #312 https://github.com/lspitzner/brittany/pull/312
because the build failed with GHC < 8.8 and the tests failed with GHC 8.10.
If you'd like to help, please see #324
https://github.com/lspitzner/brittany/pull/324.

I didn't update the demo site (https://hexagoxel.de/brittany/) because I
don't know how.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lspitzner/brittany/issues/318#issuecomment-727609835,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRJXHUR7G7UJPRMAC3LP3SQAIYHANCNFSM4S2DQDPA
.

Thanks! On Mon, Nov 16, 2020, 1:56 AM Taylor Fausak <notifications@github.com> wrote: > I have built and released the current master branch as version 0.12.2.0. > > - https://hackage.haskell.org/package/brittany-0.12.2.0 > - https://github.com/lspitzner/brittany/releases/tag/0.12.2.0 > (includes binaries) > > I didn't merge #312 <https://github.com/lspitzner/brittany/pull/312> > because the build failed with GHC < 8.8 and the tests failed with GHC 8.10. > If you'd like to help, please see #324 > <https://github.com/lspitzner/brittany/pull/324>. > > I didn't update the demo site (https://hexagoxel.de/brittany/) because I > don't know how. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/lspitzner/brittany/issues/318#issuecomment-727609835>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGRJXHUR7G7UJPRMAC3LP3SQAIYHANCNFSM4S2DQDPA> > . >

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#318