Fix formerly-accepted but incorrect cabal files #163

2018-07-13T01:02:32+02:00

typedrat commented

2018-07-13 01:02:32 +02:00

(Migrated from github.com)

install-includes: looks in your include-dirs, so you won't get it put in the right place for other components if you don't reference how you expect it to be referenced in your files.
doc-svg-gen doesn't have a ChangeLog.md, and even if it is not going to be published, it is still erroneous to list it.

Closes #162, closes haskell/cabal#5427. - `install-includes:` looks in your `include-dirs`, so you won't get it put in the right place for other components if you don't reference how you expect it to be referenced in your files. - `doc-svg-gen` doesn't have a ChangeLog.md, and even if it is not going to be published, it is still erroneous to list it.

lspitzner commented

2018-09-12 23:18:48 +02:00

(Migrated from github.com)

closing due to lack of feedback on my question in #162:

although.. i don't really see the need to expose prelude.inc outside of the package. So I guess removing "install-includes" entirely plus per-component "include-dirs" is the way to go?

closing due to lack of feedback on my question in #162: > although.. i don't really see the need to expose prelude.inc outside of the package. So I guess removing "install-includes" entirely plus per-component "include-dirs" is the way to go?

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hexagoxel/brittany#163